Deprecate unused mysqli constants #6850
Conversation
| #endif | ||
| #ifdef SERVER_PS_OUT_PARAMS | ||
| REGISTER_LONG_CONSTANT("MYSQLI_SERVER_PS_OUT_PARAMS", SERVER_PS_OUT_PARAMS, CONST_CS | CONST_PERSISTENT); | ||
| #endif |
There was a problem hiding this comment.
Just to confirm, there is no way to access server_status from mysqli?
There was a problem hiding this comment.
I don't know of any way to use these constants.
I was not aware that we can make constants deprecated. I will try to rewrite this PR now to make them deprecated instead of removing them.
|
I think that apart from ON_UPDATE_NOW_FLAG this is okay. Rather then dropping the constants entirely, we could also mark them as CONST_DEPRECATED, now that we have support for it. If there's no particular urgency here, doing that would be more in line with usual process. |
kamil-tekiela
force-pushed
the
Remove-unused-mysqli-constants
branch
from
055fa41 to
a943012
Compare
kamil-tekiela
changed the title
| 2048 | ||
|
|
||
| Deprecated: Constant MYSQLI_SERVER_PS_OUT_PARAMS is deprecated in %s | ||
| 4096 |
There was a problem hiding this comment.
I'd avoid testing specific values here -- possibly these vary by client version.
There was a problem hiding this comment.
I added %i instead. Is this better?
kamil-tekiela
force-pushed
the
Remove-unused-mysqli-constants
branch
from
73127f2 to
a8d75b8
Compare
Not mentioned anywhere in the changelogs or migration guide. Still happened. Includes unit tests. Refs: * php/php-src#6850 * php/php-src@b7a298b
Technically this is BC, but if anyone uses these constants in their code I would sincerely want to know why. From what I can tell all of them have been dead for years, if they ever were in use.
Removed:
It's possible they were used in the past or that I am wrong. If anyone knows if they are used for anything please let me know.