Refactor SNMP extension a bit #6846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use RETURN_* macros instead of RETVAL_* + return; Use proper boolean types Use zend_string instead of char* to prevent unnecessary strlen calculation
nikic
approved these changes
Apr 9, 2021
| @@ -574,7 +569,7 @@ static void php_snmp_internal(INTERNAL_FUNCTION_PARAMETERS, int st, | |||
|
|
|||
| /* OID increase check */ | |||
| if (st & SNMP_CMD_WALK) { | |||
| if (objid_query->oid_increasing_check == TRUE && snmp_oid_compare(objid_query->vars[0].name, objid_query->vars[0].name_length, vars->name, vars->name_length) >= 0) { | |||
| if (objid_query->oid_increasing_check == true && snmp_oid_compare(objid_query->vars[0].name, objid_query->vars[0].name_length, vars->name, vars->name_length) >= 0) { | |||
There was a problem hiding this comment.
Suggested change
| if (objid_query->oid_increasing_check == true && snmp_oid_compare(objid_query->vars[0].name, objid_query->vars[0].name_length, vars->name, vars->name_length) >= 0) { | |
| if (objid_query->oid_increasing_check && snmp_oid_compare(objid_query->vars[0].name, objid_query->vars[0].name_length, vars->name, vars->name_length) >= 0) { |
| @@ -668,20 +660,20 @@ static int php_snmp_parse_oid( | |||
| zval *tmp_oid, *tmp_type, *tmp_value; | |||
|
|
|||
| objid_query->count = 0; | |||
| objid_query->array_output = ((st & SNMP_CMD_WALK) ? TRUE : FALSE); | |||
| objid_query->array_output = ((st & SNMP_CMD_WALK) ? true : false); | |||
There was a problem hiding this comment.
Suggested change
| objid_query->array_output = ((st & SNMP_CMD_WALK) ? true : false); | |
| objid_query->array_output = (st & SNMP_CMD_WALK) != 0; |
| } | ||
| objid_query->vars = (snmpobjarg *)safe_emalloc(sizeof(snmpobjarg), zend_hash_num_elements(oid_ht), 0); | ||
| objid_query->array_output = ( (st & SNMP_CMD_SET) ? FALSE : TRUE ); | ||
| objid_query->array_output = ( (st & SNMP_CMD_SET) ? false : true ); |
There was a problem hiding this comment.
Suggested change
| objid_query->array_output = ( (st & SNMP_CMD_SET) ? false : true ); | |
| objid_query->array_output = (st & SNMP_CMD_SET) != 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use RETURN_* macros instead of RETVAL_* + return;
Use proper boolean types
Use zend_string instead of char* to prevent unnecessary strlen calculation