Skip to content

Spelling #6822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 124 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
124 commits
Select commit Hold shift + click to select a range
6a64a4f
spelling: abcdefghijklmnopqrstuvwxyz
jsoref Mar 31, 2021
7eca000
spelling: aborting
jsoref Mar 31, 2021
58a0438
spelling: abstract
jsoref Mar 31, 2021
58b184e
spelling: accepted
jsoref Mar 31, 2021
590e1c3
spelling: additional
jsoref Mar 31, 2021
9b5ad50
spelling: alloca'd
jsoref Mar 31, 2021
739afdf
spelling: allocated
jsoref Mar 31, 2021
d016413
spelling: ambiguities
jsoref Mar 31, 2021
6fdcbb6
spelling: and set
jsoref Mar 31, 2021
e2ee9e9
spelling: anonymous_index
jsoref Mar 31, 2021
ac43b42
spelling: appear
jsoref Mar 31, 2021
a4be4d9
spelling: append
jsoref Mar 31, 2021
c65093c
spelling: arbitrarily
jsoref Mar 31, 2021
df6f26e
spelling: arithmetic
jsoref Mar 31, 2021
e29a441
spelling: array
jsoref Mar 31, 2021
a8201aa
spelling: assignment
jsoref Mar 31, 2021
8050e8c
spelling: backtrace
jsoref Mar 31, 2021
eb2e230
spelling: breakpoint
jsoref Mar 31, 2021
2527176
spelling: bug
jsoref Apr 1, 2021
580d53d
spelling: called
jsoref Mar 31, 2021
0472362
spelling: certainly
jsoref Mar 31, 2021
26ed0f1
spelling: children
jsoref Mar 31, 2021
5b01545
spelling: collect
jsoref Mar 31, 2021
fffebe3
spelling: colliding
jsoref Mar 31, 2021
8c24114
spelling: combinable
jsoref Mar 31, 2021
490fbfd
spelling: compilation
jsoref Mar 31, 2021
9305f58
spelling: compromise
jsoref Mar 31, 2021
e628ebd
spelling: conformance
jsoref Mar 31, 2021
f65aa05
spelling: customize
jsoref Mar 31, 2021
22e87e7
spelling: deinitialize
jsoref Mar 31, 2021
ee53447
spelling: delegated
jsoref Mar 31, 2021
fca2b96
spelling: destruct
jsoref Mar 31, 2021
3fc2e72
spelling: differentiate
jsoref Mar 31, 2021
53e1c7f
spelling: elsewhere
jsoref Mar 31, 2021
73e6681
spelling: encapsulated
jsoref Mar 31, 2021
717033c
spelling: entity
jsoref Mar 31, 2021
f155ae6
spelling: execute
jsoref Mar 31, 2021
f371942
spelling: extensions
jsoref Mar 31, 2021
7c71205
spelling: finish
jsoref Mar 31, 2021
559e06f
spelling: forgotten
jsoref Mar 31, 2021
db5ed54
spelling: frequently
jsoref Mar 31, 2021
d00f948
spelling: give up
jsoref Mar 31, 2021
45e04a9
spelling: globally
jsoref Mar 31, 2021
3d106af
spelling: guaranteed to be buffered
jsoref Apr 1, 2021
a77b070
spelling: hardcoded
jsoref Mar 31, 2021
2f7a7d2
spelling: hardening
jsoref Apr 1, 2021
cbde6ee
spelling: have
jsoref Mar 31, 2021
d218243
spelling: headers
jsoref Mar 31, 2021
c1a9b39
spelling: impersonated
jsoref Mar 31, 2021
7b36145
spelling: inaccessible
jsoref Mar 31, 2021
f1ed465
spelling: incoming
jsoref Mar 31, 2021
cb64769
spelling: inconvenience
jsoref Mar 31, 2021
ed03b8e
spelling: initialized
jsoref Mar 31, 2021
29d698e
spelling: inspired
jsoref Mar 31, 2021
2e0020a
spelling: instances
jsoref Mar 31, 2021
e83f4c3
spelling: irreducible
jsoref Mar 31, 2021
8093e37
spelling: itself
jsoref Mar 31, 2021
d87b56e
spelling: jumps
jsoref Mar 31, 2021
0e977e3
spelling: large
jsoref Mar 31, 2021
6fb776b
spelling: last
jsoref Mar 31, 2021
550165e
spelling: leaks
jsoref Mar 31, 2021
754715b
spelling: log into
jsoref Mar 31, 2021
14ab262
spelling: macos
jsoref Mar 31, 2021
e12c2f7
spelling: malformed
jsoref Mar 31, 2021
3dc68ea
spelling: manually
jsoref Mar 31, 2021
eb74dd6
spelling: mechanism
jsoref Mar 31, 2021
c4708fb
spelling: member
jsoref Mar 31, 2021
3dcb9aa
spelling: modifiers
jsoref Mar 31, 2021
3a9f02f
spelling: nonexistent
jsoref Mar 31, 2021
3b9084e
spelling: notify
jsoref Mar 31, 2021
ed0c842
spelling: object
jsoref Mar 31, 2021
cf82436
spelling: opcache
jsoref Mar 31, 2021
51ab928
spelling: operations
jsoref Mar 31, 2021
9c0d254
spelling: optimize
jsoref Mar 31, 2021
9b4fe49
spelling: optint
jsoref Mar 31, 2021
697cc34
spelling: ors
jsoref Mar 31, 2021
645a1da
spelling: overflowed
jsoref Mar 31, 2021
8ce2597
spelling: overloaded
jsoref Mar 31, 2021
05ef39f
spelling: overwrite
jsoref Mar 31, 2021
6a789e3
spelling: pathological
jsoref Mar 31, 2021
09ac883
spelling: permissions
jsoref Mar 31, 2021
b2a3f68
spelling: phpdbg
jsoref Mar 31, 2021
9e4690f
spelling: phpdbginit
jsoref Mar 31, 2021
7e13610
spelling: platform
jsoref Mar 31, 2021
9a9f696
spelling: potentially
jsoref Mar 31, 2021
e3dc6ef
spelling: preparing
jsoref Mar 31, 2021
85ddbd4
spelling: preserve
jsoref Mar 31, 2021
7d11d26
spelling: processed
jsoref Mar 31, 2021
8365d18
spelling: properties
jsoref Mar 31, 2021
53bf7af
spelling: purpose
jsoref Mar 31, 2021
2350c03
spelling: quoting
jsoref Mar 31, 2021
56f0a9b
spelling: re_adding
jsoref Mar 31, 2021
738bdab
spelling: reachable
jsoref Mar 31, 2021
09b1038
spelling: rebuilding
jsoref Mar 31, 2021
bf1c7a2
spelling: receipt
jsoref Mar 31, 2021
8b6f1c3
spelling: reconstruct
jsoref Mar 31, 2021
3bdfd2b
spelling: referenceable
jsoref Mar 31, 2021
e3ff981
spelling: removes
jsoref Mar 31, 2021
a6173fd
spelling: reserved
jsoref Mar 31, 2021
0d0184b
spelling: resources
jsoref Mar 31, 2021
7ea5e8c
spelling: result
jsoref Mar 31, 2021
6bda88d
spelling: results
jsoref Mar 31, 2021
aa6549f
spelling: rewritten
jsoref Mar 31, 2021
87f2ee9
spelling: setprompt
jsoref Mar 31, 2021
1e82777
spelling: skip
jsoref Mar 31, 2021
8a474f3
spelling: source
jsoref Mar 31, 2021
92a55cf
spelling: specified
jsoref Mar 31, 2021
28093eb
spelling: stepping
jsoref Mar 31, 2021
d1bbcb1
spelling: stringify
jsoref Mar 31, 2021
289da0c
spelling: strlen
jsoref Mar 31, 2021
a012a14
spelling: structures
jsoref Mar 31, 2021
5b400fa
spelling: synonym
jsoref Mar 31, 2021
8167dfe
spelling: terminates
jsoref Mar 31, 2021
1a80856
spelling: therefore
jsoref Mar 31, 2021
13d5531
spelling: typelib
jsoref Mar 31, 2021
cddd4c6
spelling: ugly
jsoref Mar 31, 2021
70bc9fe
spelling: uninitialized
jsoref Mar 31, 2021
1ed5ea5
spelling: unqualified
jsoref Mar 31, 2021
469b067
spelling: us
jsoref Mar 31, 2021
fd74a7f
spelling: visited
jsoref Mar 31, 2021
89c8a4a
spelling: wrap-up
jsoref Mar 31, 2021
8ae474a
spelling: mechanism [API]
jsoref Mar 31, 2021
148b9ac
spelling: milli [API] fpm_log_write
jsoref Mar 31, 2021
ed225cb
spelling: unique [API]
jsoref Mar 31, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CODING_STANDARDS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
This file lists several standards that any programmer adding or changing code in
PHP should follow. Since this file was added at a very late stage of the
development of PHP v3.0, the code base does not fully follow it, but new
features are going in that general direction. Many sections have been recoded to
features are going in that general direction. Many sections have been rewritten to
use these rules.

## Code implementation
Expand Down
2 changes: 1 addition & 1 deletion NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ PHP NEWS
- MySQLnd:
. Fixed bug #80761 (PDO uses too much memory). (Nikita)

- Opcache:
- OPcache:
. Added inheritance cache. (Dmitry)

- OpenSSL:
Expand Down
2 changes: 1 addition & 1 deletion TSRM/tsrm_win32.c
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ TSRM_API int tsrm_win32_access(const char *pathname, int mode)
goto Finished;
}

/* Different identity, we need a new impersontated token as well */
/* Different identity, we need a new impersonated token as well */
if (!TWG(impersonation_token_sid) || !EqualSid(token_sid, TWG(impersonation_token_sid))) {
if (TWG(impersonation_token_sid)) {
free(TWG(impersonation_token_sid));
Expand Down
8 changes: 4 additions & 4 deletions UPGRADING
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,12 @@ PHP 8.1 UPGRADE NOTES
- PDO SQLite:
. Integers and floats in results sets will now be returned using native PHP
types. You can restore the previous behavior by enabling the
PDO::ATTR_STRINGFIY_FETCHES option.
PDO::ATTR_STRINGIFY_FETCHES option.

- Standard:
. version_compare() no longer accepts undocumented operator abbreviations.
. htmlspecialchars(), htmlentities(), htmlspecialchars_decode(),
html_entitity_decode() and get_html_translation_table() now use
html_entity_decode() and get_html_translation_table() now use
ENT_QUOTES | ENT_SUBSTITUTE rather than ENT_COMPAT by default. This means
that ' is escaped to ' while previously it was left alone.
Additionally, malformed UTF-8 will be replaced by a Unicode substitution
Expand Down Expand Up @@ -187,7 +187,7 @@ PHP 8.1 UPGRADE NOTES
echo $h, "\n";
```

A valid seed value is within the range from 0 to the plaform defined UINT_MAX, usually 4294967295.
A valid seed value is within the range from 0 to the platform defined UINT_MAX, usually 4294967295.

. Added xxHash. The implementation brings in the following arguments

Expand Down Expand Up @@ -262,7 +262,7 @@ PHP 8.1 UPGRADE NOTES
etc. was changed. Now properties are naturally ordered according to their
declaration and inheritance. Properties declared in a base class are going
to be before the child properties. This order is consistent with internal
layout of properies in zend_objct structure and repeats the order in
layout of properties in zend_object structure and repeats the order in
default_properties_table[] and properties_info_table[]. The old order was
not documented and was caused by class inheritance implementation details.

Expand Down
2 changes: 1 addition & 1 deletion Zend/Optimizer/block_pass.c
Original file line number Diff line number Diff line change
Expand Up @@ -1458,7 +1458,7 @@ static void zend_jmp_optimization(zend_basic_block *block, zend_op_array *op_arr
/* is not used on the following path and */
/* should be used once on the branch path. */
/* */
/* The pattern works well only if jums processed in */
/* The pattern works well only if jumps processed in */
/* direct order, otherwise it breaks JMPZ_EX */
/* sequences too early. */
last_op->result.var = target->result.var;
Expand Down
2 changes: 1 addition & 1 deletion Zend/Optimizer/dce.c
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ int dce_optimize_op_array(zend_op_array *op_array, zend_ssa *ssa, bool reorder_d
ctx.phi_dead = alloca(sizeof(zend_ulong) * ctx.phi_worklist_len);
memset(ctx.phi_dead, 0xff, sizeof(zend_ulong) * ctx.phi_worklist_len);

/* Mark reacable instruction without side effects as dead */
/* Mark reachable instruction without side effects as dead */
int b = ssa->cfg.blocks_count;
while (b > 0) {
int op_data = -1;
Expand Down
12 changes: 6 additions & 6 deletions Zend/Optimizer/pass1.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ void zend_optimizer_pass1(zend_op_array *op_array, zend_optimizer_ctx *ctx)
|| opline->extended_value == ZEND_DIV
|| opline->extended_value == ZEND_POW) {
if (Z_TYPE(ZEND_OP2_LITERAL(opline)) == IS_STRING) {
/* don't optimise if it should produce a runtime numeric string error */
/* don't optimize if it should produce a runtime numeric string error */
if (is_numeric_string(Z_STRVAL(ZEND_OP2_LITERAL(opline)), Z_STRLEN(ZEND_OP2_LITERAL(opline)), NULL, NULL, 0)) {
convert_scalar_to_number(&ZEND_OP2_LITERAL(opline));
}
Expand All @@ -120,7 +120,7 @@ void zend_optimizer_pass1(zend_op_array *op_array, zend_optimizer_ctx *ctx)
|| opline->extended_value == ZEND_SL
|| opline->extended_value == ZEND_SR) {
if (Z_TYPE(ZEND_OP2_LITERAL(opline)) != IS_LONG) {
/* don't optimise if it should produce a runtime numeric string error */
/* don't optimize if it should produce a runtime numeric string error */
if (!(Z_TYPE(ZEND_OP2_LITERAL(opline)) == IS_STRING
&& !is_numeric_string(Z_STRVAL(ZEND_OP2_LITERAL(opline)), Z_STRLEN(ZEND_OP2_LITERAL(opline)), NULL, NULL, 0))) {
convert_to_long(&ZEND_OP2_LITERAL(opline));
Expand Down Expand Up @@ -312,7 +312,7 @@ void zend_optimizer_pass1(zend_op_array *op_array, zend_optimizer_ctx *ctx)
}
if (send1_opline->opcode != ZEND_SEND_VAL ||
send1_opline->op1_type != IS_CONST) {
/* don't colllect constants after unknown function call */
/* don't collect constants after unknown function call */
collect_constants = 0;
break;
}
Expand All @@ -324,7 +324,7 @@ void zend_optimizer_pass1(zend_op_array *op_array, zend_optimizer_ctx *ctx)
}
if (send1_opline->opcode != ZEND_SEND_VAL ||
send1_opline->op1_type != IS_CONST) {
/* don't colllect constants after unknown function call */
/* don't collect constants after unknown function call */
collect_constants = 0;
break;
}
Expand All @@ -336,7 +336,7 @@ void zend_optimizer_pass1(zend_op_array *op_array, zend_optimizer_ctx *ctx)
if (init_opline->opcode != ZEND_INIT_FCALL ||
init_opline->op2_type != IS_CONST ||
Z_TYPE(ZEND_OP2_LITERAL(init_opline)) != IS_STRING) {
/* don't colllect constants after unknown function call */
/* don't collect constants after unknown function call */
collect_constants = 0;
break;
}
Expand Down Expand Up @@ -505,7 +505,7 @@ void zend_optimizer_pass1(zend_op_array *op_array, zend_optimizer_ctx *ctx)
break;
}
}
/* don't colllect constants after any other function call */
/* don't collect constants after any other function call */
collect_constants = 0;
break;
}
Expand Down
2 changes: 1 addition & 1 deletion Zend/Optimizer/pass3.c
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ void zend_optimizer_pass3(zend_op_array *op_array, zend_optimizer_ctx *ctx)
/* is not used on the following path and */
/* should be used once on the branch path. */
/* */
/* The pattern works well only if jums processed in */
/* The pattern works well only if jumps processed in */
/* direct order, otherwise it breaks JMPZ_EX */
/* sequences too early. */
opline->result.var = target->result.var;
Expand Down
2 changes: 1 addition & 1 deletion Zend/Optimizer/zend_call_graph.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ struct _zend_call_info {
struct _zend_func_info {
int num;
uint32_t flags;
zend_ssa ssa; /* Static Single Assignmnt Form */
zend_ssa ssa; /* Static Single Assignment Form */
zend_call_info *caller_info; /* where this function is called from */
zend_call_info *callee_info; /* which functions are called from this one */
zend_call_info **call_map; /* Call info associated with init/call/send opnum */
Expand Down
2 changes: 1 addition & 1 deletion Zend/Optimizer/zend_dump.c
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,7 @@ ZEND_API void zend_dump_op_array(const zend_op_array *op_array, uint32_t dump_fl
}
}
if (func_flags & ZEND_FUNC_IRREDUCIBLE) {
fprintf(stderr, ", irreducable");
fprintf(stderr, ", irreducible");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully debug, but to match the line above...

}
if (func_flags & ZEND_FUNC_NO_LOOPS) {
fprintf(stderr, ", no_loops");
Expand Down
2 changes: 1 addition & 1 deletion Zend/Optimizer/zend_inference.c
Original file line number Diff line number Diff line change
Expand Up @@ -3778,7 +3778,7 @@ static bool is_effective_op2_double_cast(zend_op *opline, zval *op1) {
* E.g. 0+$i and 0.0+$i only differ by that cast. If then the consuming instruction of this
* result will perform a double cast anyway, the conversion is safe.
*
* The checks happens recursively, while keeping track of which variables are already visisted to
* The checks happens recursively, while keeping track of which variables are already visited to
* avoid infinite loops. An iterative, worklist driven approach would be possible, but the state
* management more cumbersome to implement, so we don't bother for now.
*/
Expand Down
2 changes: 1 addition & 1 deletion Zend/Optimizer/zend_optimizer_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ zend_function *zend_optimizer_get_called_func(
uint32_t zend_optimizer_classify_function(zend_string *name, uint32_t num_args);
void zend_optimizer_migrate_jump(zend_op_array *op_array, zend_op *new_opline, zend_op *opline);
void zend_optimizer_shift_jump(zend_op_array *op_array, zend_op *opline, uint32_t *shiftlist);
int sccp_optimize_op_array(zend_optimizer_ctx *ctx, zend_op_array *op_arrya, zend_ssa *ssa, zend_call_info **call_map);
int sccp_optimize_op_array(zend_optimizer_ctx *ctx, zend_op_array *op_array, zend_ssa *ssa, zend_call_info **call_map);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal

int dce_optimize_op_array(zend_op_array *op_array, zend_ssa *ssa, bool reorder_dtor_effects);
int zend_ssa_escape_analysis(const zend_script *script, zend_op_array *op_array, zend_ssa *ssa);

Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/list/list_reference_010.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
list(&$foo) = [42];
?>
--EXPECTF--
Fatal error: Cannot assign reference to non referencable value in %s on line %d
Fatal error: Cannot assign reference to non referenceable value in %s on line %d
2 changes: 1 addition & 1 deletion Zend/tests/list/list_reference_011.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ const FOO = 10;
[&$f] = FOO;
?>
--EXPECTF--
Fatal error: Cannot assign reference to non referencable value in %s on line %d
Fatal error: Cannot assign reference to non referenceable value in %s on line %d
2 changes: 1 addition & 1 deletion Zend/tests/restrict_globals/invalid_assign_list_ref.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ list(&$GLOBALS) = [1];

?>
--EXPECTF--
Fatal error: Cannot assign reference to non referencable value in %s on line %d
Fatal error: Cannot assign reference to non referenceable value in %s on line %d
6 changes: 3 additions & 3 deletions Zend/zend.c
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,7 @@ void zend_startup(zend_utility_functions *utility_functions) /* {{{ */
#endif
# if ZEND_MAP_PTR_KIND == ZEND_MAP_PTR_KIND_PTR
/* Create a map region, used for indirect pointers from shared to
* process memory. It's allocatred once and never resized.
* process memory. It's allocated once and never resized.
* All processes must map it into the same address space.
*/
CG(map_ptr_size) = 1024 * 1024; // TODO: initial size ???
Expand Down Expand Up @@ -1374,8 +1374,8 @@ static ZEND_COLD void zend_error_impl(
ZVAL_COPY_VALUE(&orig_user_error_handler, &EG(user_error_handler));
ZVAL_UNDEF(&EG(user_error_handler));

/* User error handler may include() additinal PHP files.
* If an error was generated during comilation PHP will compile
/* User error handler may include() additional PHP files.
* If an error was generated during compilation PHP will compile
* such scripts recursively, but some CG() variables may be
* inconsistent. */

Expand Down
2 changes: 1 addition & 1 deletion Zend/zend_API.c
Original file line number Diff line number Diff line change
Expand Up @@ -2899,7 +2899,7 @@ void module_destructor(zend_module_entry *module) /* {{{ */
zend_unregister_ini_entries(module->module_number);
}

/* Deinitilaise module globals */
/* Deinitialize module globals */
if (module->globals_size) {
#ifdef ZTS
if (*module->globals_id_ptr) {
Expand Down
2 changes: 1 addition & 1 deletion Zend/zend_API.h
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ ZEND_API void zend_fcall_info_args_clear(zend_fcall_info *fci, bool free_mem);
*/
ZEND_API void zend_fcall_info_args_save(zend_fcall_info *fci, uint32_t *param_count, zval **params);

/** Free arguments connected with zend_fcall_info *fci andset back saved ones.
/** Free arguments connected with zend_fcall_info *fci and set back saved ones.
*/
ZEND_API void zend_fcall_info_args_restore(zend_fcall_info *fci, uint32_t param_count, zval *params);

Expand Down
2 changes: 1 addition & 1 deletion Zend/zend_alloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ int zend_mm_use_huge_pages = 0;
* free_tail - number of continuous free pages at the end of chunk
*
* free_map - bitset (a bit for each page). The bit is set if the corresponding
* page is allocated. Allocator for "lage sizes" may easily find a
* page is allocated. Allocator for "large sizes" may easily find a
* free page (or a continuous number of pages) searching for zero
* bits.
*
Expand Down
2 changes: 1 addition & 1 deletion Zend/zend_builtin_functions.c
Original file line number Diff line number Diff line change
Expand Up @@ -1922,7 +1922,7 @@ ZEND_API void zend_fetch_debug_backtrace(zval *return_value, int skip_last, int
zend_hash_add_new(Z_ARRVAL(stack_frame), ZSTR_KNOWN(ZEND_STR_LINE), &tmp);

/* try to fetch args only if an FCALL was just made - elsewise we're in the middle of a function
* and debug_baktrace() might have been called by the error_handler. in this case we don't
* and debug_backtrace() might have been called by the error_handler. in this case we don't
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* want to pop anything of the argument-stack */
} else {
zend_execute_data *prev_call = skip;
Expand Down
6 changes: 3 additions & 3 deletions Zend/zend_compile.c
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ static int zend_add_ns_func_name_literal(zend_string *name) /* {{{ */
zend_string *lc_name = zend_string_tolower(name);
zend_add_literal_string(&lc_name);

/* Lowercased unqualfied name */
/* Lowercased unqualified name */
if (zend_get_unqualified_name(name, &unqualified_name, &unqualified_name_len)) {
lc_name = zend_string_alloc(unqualified_name_len, 0);
zend_str_tolower_copy(ZSTR_VAL(lc_name), unqualified_name, unqualified_name_len);
Expand Down Expand Up @@ -715,7 +715,7 @@ void zend_do_free(znode *op1) /* {{{ */
switch (opline->opcode) {
case ZEND_BOOL:
case ZEND_BOOL_NOT:
/* boolean resuls don't have to be freed */
/* boolean results don't have to be freed */
return;
case ZEND_POST_INC_STATIC_PROP:
case ZEND_POST_DEC_STATIC_PROP:
Expand Down Expand Up @@ -3230,7 +3230,7 @@ void zend_compile_assign(znode *result, zend_ast *ast) /* {{{ */
if (zend_propagate_list_refs(var_ast)) {
if (!zend_is_variable_or_call(expr_ast)) {
zend_error_noreturn(E_COMPILE_ERROR,
"Cannot assign reference to non referencable value");
"Cannot assign reference to non referenceable value");
}

zend_compile_var(&expr_node, expr_ast, BP_VAR_W, 1);
Expand Down
6 changes: 3 additions & 3 deletions Zend/zend_compile.h
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ typedef struct _zend_oparray_context {
/* op_array or class is preloaded | | | */
#define ZEND_ACC_PRELOADED (1 << 10) /* X | X | | */
/* | | | */
/* Flag to differenciate cases from constants. | | | */
/* Flag to differentiate cases from constants. | | | */
/* Stored in Z_ACCESS_FLAGS, must not conflict with | | | */
/* ZEND_ACC_ visibility flags or IS_CONSTANT_VISITED_MARK | | | */
#define ZEND_CLASS_CONST_IS_CASE (1 << 6) /* | | | X */
Expand Down Expand Up @@ -1103,15 +1103,15 @@ END_EXTERN_C()
#define ZEND_COMPILE_EXTENDED_FCALL (1<<1)
#define ZEND_COMPILE_EXTENDED_INFO (ZEND_COMPILE_EXTENDED_STMT|ZEND_COMPILE_EXTENDED_FCALL)

/* call op_array handler of extendions */
/* call op_array handler of extensions */
#define ZEND_COMPILE_HANDLE_OP_ARRAY (1<<2)

/* generate ZEND_INIT_FCALL_BY_NAME for internal functions instead of ZEND_INIT_FCALL */
#define ZEND_COMPILE_IGNORE_INTERNAL_FUNCTIONS (1<<3)

/* don't perform early binding for classes inherited form internal ones;
* in namespaces assume that internal class that doesn't exist at compile-time
* may apper in run-time */
* may appear in run-time */
#define ZEND_COMPILE_IGNORE_INTERNAL_CLASSES (1<<4)

/* generate ZEND_DECLARE_CLASS_DELAYED opcode to delay early binding */
Expand Down
2 changes: 1 addition & 1 deletion Zend/zend_constants.h
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ ZEND_API void zend_register_string_constant(const char *name, size_t name_len, c
ZEND_API void zend_register_stringl_constant(const char *name, size_t name_len, const char *strval, size_t strlen, int flags, int module_number);
ZEND_API zend_result zend_register_constant(zend_constant *c);
#ifdef ZTS
void zend_copy_constants(HashTable *target, HashTable *sourc);
void zend_copy_constants(HashTable *target, HashTable *source);
#endif

ZEND_API zend_constant *_zend_get_special_const(const char *name, size_t name_len);
Expand Down
2 changes: 1 addition & 1 deletion Zend/zend_exceptions.c
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ static zend_object_handlers default_exception_handlers;
/* {{{ zend_implement_throwable */
static int zend_implement_throwable(zend_class_entry *interface, zend_class_entry *class_type)
{
/* zend_ce_exception and zend_ce_error may not be initialized yet when this is caleld (e.g when
/* zend_ce_exception and zend_ce_error may not be initialized yet when this is called (e.g when
* implementing Throwable for Exception itself). Perform a manual inheritance check. */
zend_class_entry *root = class_type;
while (root->parent) {
Expand Down
2 changes: 1 addition & 1 deletion Zend/zend_execute.h
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ struct _zend_vm_stack {
/*
* In general in RELEASE build ZEND_ASSERT() must be zero-cost, but for some
* reason, GCC generated worse code, performing CSE on assertion code and the
* following "slow path" and moving memory read operatins from slow path into
* following "slow path" and moving memory read operations from slow path into
* common header. This made a degradation for the fast path.
* The following "#if ZEND_DEBUG" eliminates it.
*/
Expand Down
2 changes: 1 addition & 1 deletion Zend/zend_generators.c
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ ZEND_API void zend_generator_resume(zend_generator *orig_generator) /* {{{ */
orig_generator->flags &= ~ZEND_GENERATOR_DO_INIT;
return;
}
/* If there are no more deletegated values, resume the generator
/* If there are no more delegated values, resume the generator
* after the "yield from" expression. */
}

Expand Down
2 changes: 1 addition & 1 deletion Zend/zend_globals.h
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ struct _zend_executor_globals {

zend_long assertions;

uint32_t ht_iterators_count; /* number of allocatd slots */
uint32_t ht_iterators_count; /* number of allocated slots */
uint32_t ht_iterators_used; /* number of used slots */
HashTableIterator *ht_iterators;
HashTableIterator ht_iterators_slots[16];
Expand Down
2 changes: 1 addition & 1 deletion Zend/zend_hash.c
Original file line number Diff line number Diff line change
Expand Up @@ -1842,7 +1842,7 @@ ZEND_API void ZEND_FASTCALL zend_hash_graceful_reverse_destroy(HashTable *ht)
* return codes are possible:
* ZEND_HASH_APPLY_KEEP - continue
* ZEND_HASH_APPLY_STOP - stop iteration
* ZEND_HASH_APPLY_REMOVE - delete the element, combineable with the former
* ZEND_HASH_APPLY_REMOVE - delete the element, combinable with the former
*/

ZEND_API void ZEND_FASTCALL zend_hash_apply(HashTable *ht, apply_func_t apply_func)
Expand Down
Loading