Skip to content

Fix #73533: Invalid memory access in php_libxml_xmlCheckUTF8 #6802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #73533: Invalid memory access in php_libxml_xmlCheckUTF8 #6802

wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Mar 23, 2021

A string passed to php_libxml_xmlCheckUTF8() may be longer than
1<<31-1 bytes, so we're better using a size_t.

@cmb69
Fix #73533: Invalid memory access in php_libxml_xmlCheckUTF8
ed48f7f 
A string passed to `php_libxml_xmlCheckUTF8()` may be longer than
1<<31-1 bytes, so we're better using a `size_t`.
@cmb69 cmb69 added the Bug label Mar 23, 2021
nikic
nikic approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay, although in this instance I'd maybe use *s++ rather than s[i++] and drop i entirely.

@cmb69
Copy link
Member Author

cmb69 commented Mar 24, 2021

Ah, right. I'll leave that for another day. :)

@php-pulls php-pulls closed this in 498eb8e Mar 24, 2021
@cmb69 cmb69 deleted the cmb/73533 branch March 24, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmb69 @nikic