Skip to content

Add clean to MySQL tests #6756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kamil-tekiela
Copy link
Member

I don't like when PHP tests don't clean up after themselves.

Copy link
Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are now using the same table/procedure names, do you need to make sure those tests don't run in parallel?

@kamil-tekiela
Copy link
Member Author

@staabm Maybe, but I can't even test parallel execution due to the OPCache bug. Do you know what I need to change to make them work in parallel mode?

Copy link

@Anonymous-231 Anonymous-231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trash

@cmb69
Copy link
Member

cmb69 commented Mar 10, 2021

I'm not sure to which OPcache bug you are referring, but if can't run in parallel with OPcache, consider to not enable it in the first place.

Anyhow, the table names need to be unique, or the conflicting tests have to be marked as such. The former is preferable.

@kamil-tekiela
Copy link
Member Author

@cmb69 I was referring to the bug that got fixed this morning. Anyway, I tested with -j4 and all test cases run as expected. I don't know how the conflicts file works, but I assume that mysqli and PDO tests are conflicting with each other and they will never run in parallel. I analysed the tests I changed and I see no reason why these particular ones should have unique table names. All other ones use test table.

@staabm To answer your concern, I don't think I need to do anything special in regards to parallel processing. It works just as all the other ones do in mysqli and PDO.

@cmb69
Copy link
Member

cmb69 commented Mar 10, 2021

Ah, right, these tests don't run in parallel, because there is a CONFLICTS file.

@php-pulls php-pulls closed this in 8573eb9 Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants