Declare SNMP properties #6742
Closed
Declare SNMP properties #6742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Mar 1, 2021
nikic
reviewed
Mar 1, 2021
nikic
reviewed
Mar 2, 2021
nikic
reviewed
Mar 15, 2021
nikic
reviewed
Mar 15, 2021
|
Heh, it looks like ext/pdo_sqlite/tests/bug44327_2.phpt tests the case where there is a column called queryString. I think you can just change the test expectation, but need to do so consistently (i.e. read queryString first in all handlers). |
kocsismate
force-pushed
the
stub-pdorow
branch
2 times, most recently
from
a034766 to
2c23552
Compare
|
The PDO part looks good to me. |
|
And have you come to a conclusion about the SNMP related parts? |
kocsismate
commented
Apr 27, 2021
|
I think this PR should be fairly ready - apart from the question I had above. Can you please have a look, @nikic ? |
kocsismate
commented
May 14, 2021
nikic
approved these changes
May 14, 2021
I haven't added the expectation for the new test case, but I'll do so during applying the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.