run-tests: fixed exit code not being set on BORKED tests when no test… #6717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… paths are specified this shows up when 'make test' is used on a PECL extension without specifying tests to run (or in php-src too, I guess...)
|
@cmb69 Thoughts on PHP-7.3 target for a run-tests.php fix? |
|
I think this is okay for PHP 7.3. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… paths are specified
this shows up when 'make test' is used on a PECL extension without specifying tests to run (or in php-src too, I guess...)
It produced a bug which I found unexpectedly difficult to reproduce; it turns out there are actually 2 places where run-tests exits, and the other exit point handles BORKED correctly:
php-src/run-tests.php
Line 879 in 06c9633
Side note: I discovered this due to an XLEAK section in one of my tests which wasn't recognized by 7.3's run-tests.php. It would be nice if it was supported, even if it's ignored.