-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Improve class entry generation #6701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After making the functions static, the compiler could detect that |
@kocsismate I don't think that should be a supported use-case. Why declare classes in the stub if they don't actually get declared? |
@nikic After thinking about it a little bit, I realized that you are right. My initial idea was that the reason of not using a class entry generator function could be that it is missing a needed feature (e.g. gen_stub.php doesn't yet support generating properties with a union type of multiple classes, or with constant default values). However, my argument was bad, since the missing features can be fixed up later manually (e.g. by declaring the missing properties after the ce registration). That said, I'll fix the issue by declaring the missing classes. :) |
I'm currently working on adding support for generating properties with an union type of multiple classes. |
ac6444b
to
77b33eb
Compare
Can you please land the first two commits to reduce the diff? |
77b33eb
to
02d5362
Compare
02d5362
to
ccce826
Compare
No description provided.