Generate ext/intl class entries from stubs #6670
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
force-pushed
the
stub-ce3
branch
4 times, most recently
from
432758b to
6208fa2
Compare
kocsismate
commented
Feb 6, 2021
| @@ -0,0 +1,12 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Unfortuantely, I couldn't register IntlPartsIterator without extracting its stub to its own file, even though I tried multiple approaches.
There was a problem hiding this comment.
The problem was that originally, breakiterator_arginfo.h had to be included both in breakiterator_class.cpp and breakiterator_iterators.cpp, so that the class registering functions (e.g. register_class_IntlPartsIterator) became duplicate symbols.
nikic
reviewed
Feb 8, 2021
nikic
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.