Properly render 2+ namespaces functions in build/gen_stub.php #6664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please adjust the zend_test stub to check this? |
Affects both INIT_NS_CLASS_ENTRY and ZEND_NS_FE Add test cases of the global function and namespaced values
TysonAndre
force-pushed
the
fix-namespace-build-stub
branch
from
9044a89 to
bab36ad
Compare
nikic
approved these changes
Feb 6, 2021
|
Should this be backported to the first version introducing gen_stubs.php (PHP-8.0) for global functions? I assume it should be for a bug fix. |
|
@TysonAndre Yes, applying this to PHP-8.0 is fine. |
php-pulls
pushed a commit
that referenced
this pull request
Feb 6, 2021
Affects ZEND_NS_FE Add test cases of the global function Backported to php 8.0 from GH-6664
|
Thanks for fixing this; needed it just today and was happy to find it was already fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects both INIT_NS_CLASS_ENTRY and ZEND_NS_FE
@nikic FYI - This seems to work for a name such as
PHP\iterable\anyand a class. Previously,INIT_NS_CLASS_ENTRY(ce, "Foo\Bar", "X", class_Foo_Bar_X_methods);would be generated instead of"Foo\\Bar"Should this be backported to PHP-8.0 for global functions?