gen_stub: Also verify implementation-alias #6615
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
--verify
also check@implementation-alias
. Failures are ignored using@no-verify
instead. Some mistakes have been made that would have been caught by this...There is one remaining failure:
Another example of
greatterrible API design in SPL. Converting a file into a string returns ... the current line. Which can return false. Probably the alias here needs to be dropped and we should return "" instead of false.