Fixed parameter type of Phar::setStub() #6596
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs say string only, but after examining the code it's apparent that both resource _and_ string are accepted.
kocsismate
reviewed
Jan 12, 2021
|
I've merged this with additional fixes for the issue that @kocsismate mentioned, as well as an update of PharData, which should have the same signatures as Phar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs say string only, but after examining the code it's apparent that both resource and string are accepted.
While this currently doesn't affect anything functionally, these docs are used by static analysers that use these stubs, such as PHPStan.