-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add MSSQL setup to Azure Pipelines build #6569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you add a README at the same time in the tests folder for PDO DBLIB so that one can reproduce it locally in some way? |
@nikic, could you let me know if this looks good to merge? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you! Could you please squash the commits when merging?
@nikic, yes, I'll definitely squash them. I just tried to push and I don't have karma for the azure directory. Is that something you can grant me? |
@adambaratz Done, might take a while to propagate. |
Merged with b569698. |
Looks like there's some test failures in nightly builds: https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=14085&view=ms.vss-test-web.build-test-results-tab There's two failing tests:
|
Thanks for flagging. I'll take a look later today. |
Looks like the ext/pdo_dblib/tests/bug_50755.phpt test still occasionally fails with the following error: https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=14292&view=ms.vss-test-web.build-test-results-tab&runId=323892&resultId=107600&paneView=debug This happens on the REPEAT job, which means that the same test is run two times in the same process ( |
There's still common failures in ext/pdo_dblib/tests/bug_50755.phpt with
@adambaratz Do you have any idea what is causing this? Otherwise I'll just mark the test as skipped on this job. Though it does look like it could be a legitimate issue. |
I'm okay skipping this test. The test is trying to run a query that uses too much memory. I'm guessing the test worked in a different environment, but it's dependent enough on how MSSQL handles the query that it's exercising MSSQL just as much as it's exercising pdo_dblib. |
No description provided.