Add test about invalid comparison with GMP objects #6553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Jan 4, 2021
| if (Z_TYPE(result) == IS_FALSE) { | ||
| return 1; | ||
| } | ||
| /* result can only be a zend_long if gmp_cmp hasn't thrown an Error */ |
There was a problem hiding this comment.
Shouldn't this for an EG(exception) check then? Z_LVAL(result) may not be set if an exception has been thrown.
There was a problem hiding this comment.
Probably should, but I initially dropped this as I was expecting some kind of memory read error or segfault but that didn't happen, will update this.
There was a problem hiding this comment.
Please add a ZEND_ASSERT(Z_TYPE(result) == IS_LONG); here.
Also remove some dead code
Girgias
force-pushed
the
gmp-cmp-refactor
branch
from
ad528e7 to
a508349
Compare
nikic
approved these changes
Jan 4, 2021
| if (Z_TYPE(result) == IS_FALSE) { | ||
| return 1; | ||
| } | ||
| /* result can only be a zend_long if gmp_cmp hasn't thrown an Error */ |
There was a problem hiding this comment.
Please add a ZEND_ASSERT(Z_TYPE(result) == IS_LONG); here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove some dead code.
I'm not sure if this might not be a bug? I don't exactly remember the exact semantics about comparisons.