Skip to content

Fix Bug #80560: Strings containing only a base prefix return 0 object #6549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix Bug #80560: Strings containing only a base prefix return 0 object #6549

wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Dec 29, 2020

Targets PHP 8.0 as this is long standing behaviour and not sure if it's worth to fix in PHP 7.4, as it's also a BC breaking change.

cmb69
cmb69 approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that passing an empty string is an error, it makes sense to disallow this as well. I agree that the fix should target 8.0+.

@php-pulls php-pulls closed this in abecaab Dec 30, 2020
@Girgias Girgias deleted the gmp-fix-weird-numbers branch January 4, 2021 13:20
@Girgias Girgias mentioned this pull request Jan 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @cmb69