FTP: Disallow direct FTPConnection construction
#6533
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayesh
force-pushed
the
ftpconnection-ctor
branch
from
ee0ef78 to
a10f80e
Compare
Similar to other resource to object migrations, `FTPConnection` class is not allowed to be constructed with `new FTPConnection`. Related to b4503fb.
Ayesh
force-pushed
the
ftpconnection-ctor
branch
from
a10f80e to
5726daf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to other resource to object migrations,
FTPConnectionclass is not allowed to be constructed withnew FTPConnection.Related to b4503fb.
As of now, it is possible to construct an
FTPConnectionobject withnew FTPConnection. @sgolemon did an amazing work with the resource to object migration, but I think this was overlooked? I put together this PR that basically throws an exception similar to other resource-class objects when usingnew FTPConnection, forcing users to continue to useftp_connectandftp_ssl_connect.Thank you.