Skip to content

Optimize Dovecot configuration for IMAP tests #6531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Dec 22, 2020

This halves the time taken by the SKIPIF section with parallel testing when the ext/imap/tests/imap_errors_basic.phpt is running (and possibly others) as it's hogging the connections by providing an invalid password.

Another possibility is to reduce the number of attempts in the SKIPIF section, as it turns out the retries parameter, actually corresponds to "attempts" and using 0, just retries until the mail-server terminates the connection after too many retries/too long.

@cmb69 could you test that the modification to the test still work on Windows?

@php-pulls php-pulls closed this in a80a029 Dec 22, 2020
@Girgias Girgias deleted the imap-quicker-failure branch December 22, 2020 18:56
@cmb69
Copy link
Member

cmb69 commented Dec 22, 2020

Looks good here:

Number of tests :   82                81
Tests skipped   :    1 (  1.2%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    0 (  0.0%) (  0.0%)
Tests passed    :   81 ( 98.8%) (100.0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants