Bump minimum re2c version to 0.13.7 #6516
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently merged PR #6464, but that fix actually requires re2c 0.13.7 (released 2014-07-25), while the current requirement of PHP-8.0 is re2c 0.13.4 (released 2008-04-05). That bugfix has been reverted from PHP-7.4.14, because PHP 7.4 is packaged with re2c 0.13.5, but PHP 8.0.0RC1 has it, becaused it's packaged with re2c 0.16.0. Given that users building from the release tarballs would not be affected by this re2c version bump at all, and that the minimum required version has been released more than six years ago, in my opinion this late requirements bump is acceptable.
@sgolemon, @carusogabriel, what do you think?