Skip to content

Upload coverage data to codecov.io #6486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Upload coverage data to codecov.io #6486

wants to merge 2 commits into from

Conversation

pcrov
Copy link
Contributor

@pcrov pcrov commented Dec 3, 2020

This should make code coverage available at https://app.codecov.io/gh/php/php-src looking similar to this minimal test I did via github actions https://app.codecov.io/gh/pcrov/php-src.

@carusogabriel
Copy link
Contributor

Appreciate this one 🙏

Since we moved to MS Azure, the Coverage information is only limited to admins, it's not open source. Once, and if, we merge this one, I'll spread the news, I had a bunch of PHP user groups asking me about it to bring back the PHP Test Fest

@nikic
Copy link
Member

nikic commented Dec 3, 2020

@carusogabriel I believe this bug was fixed at some point (can you access https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=13322&view=codecoverage-tab ?). But even if accessible, it's not easy to find...

@carusogabriel
Copy link
Contributor

@nikic Thanks for sharing it, I didn't know. I have a bug report at bugs.php.net, I'll mention it there.

I can access it but indeed, it's not easy to find

@nikic
Copy link
Member

nikic commented Dec 3, 2020

Looks like it did something at least. Not seeing anything on codecov.io though. Does it need to be merged into master first?

@pcrov
Copy link
Contributor Author

pcrov commented Dec 3, 2020

@nikic https://app.codecov.io/gh/php/php-src will show whatever is set up as the default branch for the default project dashboard, which should by default be master. Default default default. You can see what just ran at https://app.codecov.io/gh/php/php-src/branch/merge (found via the Branches tab.)

@php-pulls php-pulls closed this in 8f8e6f9 Dec 3, 2020
@nikic
Copy link
Member

nikic commented Dec 3, 2020

@pcrov Thanks. I tried that before, but nothing showed up ... apparently their interface is broken (at least in Firefox) and you need to reload the page after navigating to the branch.

@pcrov pcrov deleted the codecov branch December 3, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants