Skip to content

Fix mysqli_get_client_stats test #6459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

grooverdan
Copy link
Contributor

MySQL removed RENAME DATABASE in 18300001c1dbbfddf9a0adcbaeea68956102bdd0
(Sept 2007, 5.1.23). As this briefest existence is very insignificant lets remove it.

It also breaks when testing against MariaDB.

As the alternate path in this test covers all supported MySQL and MariaDB
versions and a significant portion of unsupported versions, so lets keep it simple.

MySQL removed RENAME DATABASE in 18300001c1dbbfddf9a0adcbaeea68956102bdd0
(Sept 2007, 5.1.23). As this briefest existance is very insignificant lets remove it.

It also breaks when testing against MariaDB.

As the alternate path in this test covers all supported MySQL and MariaDB
versions and a signifant portion of unsupported versions lets keep it simple.
@nikic
Copy link
Member

nikic commented Nov 27, 2020

Looks like this was fixed on the PHP-7.4 branch in c4cbdfa.

@cmb69 Is the PHP-7.3 branch still open for non-security fixes?

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 7.3.26 is going to be the last bugfix release.

@php-pulls php-pulls closed this in 4a10037 Nov 27, 2020
@grooverdan grooverdan deleted the mysqli_get_client_stats_test_fix branch November 27, 2020 11:42
@grooverdan
Copy link
Contributor Author

Thanks, and thanks for the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants