Skip to content

Fix #80312: change default engine from MyISAM to InnoDB #6405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

marinesovitch
Copy link
Contributor

change mysqli and pdo_mysql tests configuration to use by default
InnoDB instead of MyISAM

change mysqli and pdo_mysql tests configuration to use by default
InnoDB instead of MyISAM
@marinesovitch
Copy link
Contributor Author

I've checked logs under
https://dev.azure.com/phpazuredevops/eb1f6f74-bc61-47a6-a414-0e3ff41c9bb4/_build/results?buildId=12813
and from what I see, there has failed one test:
ext/sockets/tests/socket_getopt.phpt
in following line:
echo "interface 1:\n";
$r = socket_set_option($s, $level, IP_MULTICAST_IF, 1);

but I don't see how changes from my pull-request could affect it. Is there any chance that it has failed by accident due to other random reasons related to building host?

@php-pulls php-pulls closed this in 79a606b Nov 17, 2020
@nikic
Copy link
Member

nikic commented Nov 17, 2020

@marinesovitch Yeah, that's a spurious failure. I forgot to merge this PR after approving, which I've remedied now :)

@marinesovitch
Copy link
Contributor Author

ufff thnx! that's good - my first PHP pull request successfully submitted && merged :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants