Skip to content

IMAP throw Value/TypeError on invalid bodies in imap_mail_compose() #6371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

IMAP throw Value/TypeError on invalid bodies in imap_mail_compose() #6371

wants to merge 3 commits into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Oct 22, 2020

Doing some drive-by refactoring and hopefully can get rid of the %a modifier in the test as this has bitten me before...

cmb69
cmb69 approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me (I mean the PR, not that function implementation).

@php-pulls php-pulls closed this in 158d308 Oct 23, 2020
@Girgias Girgias deleted the imap-tweaks branch October 23, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @cmb69