Properly fix #80220 #6341
Closed
Properly fix #80220 #6341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original fix for that bug[1] broke the formerly working composition of message/rfc822 messages, which results in a segfault when freeing the message body now. While `imap_mail_compose()` does not really support composition of meaningful message/rfc822 messages (although libc-client appears to support that), some code may still use this to compose partial messages, and using string manipulation to create the final message. As such, we fix this to avoid a regression. [1] <http://git.php.net/?p=php-src.git;a=commit;h=0d022ddf03c5fabaaa22e486d1e4a367ed9170a7>
|
Ugh, more strangeness to deal with; switching to draft. |
|
Ah, strangeness resolved. From https://bugs.php.net/bug.php?id=80242:
So the patch looks good (assuming that libc-client handling didn't change). |
|
Closing in favor of PR #6343. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original fix for that bug[1] broke the formerly working composition
of message/rfc822 messages, which results in a segfault when freeing
the message body now. While
imap_mail_compose()does not reallysupport composition of meaningful message/rfc822 messages (although
libc-client appears to support that), some code may still use this to
compose partial messages, and using string manipulation to create the
final message. As such, we fix this to avoid a regression.
[1] http://git.php.net/?p=php-src.git;a=commit;h=0d022ddf03c5fabaaa22e486d1e4a367ed9170a7
This fix is most ugly, but apparently libc-client uses the same distinction in multiple places to dispatch to the
nestedunion members. I have not attached a test for this issue, because composing message/rfc822 messages inevitably leaks at least a single byte. I should also mention that this patch doesn't fix the guaranteed segfault if somebody tries to compose a multipart message with a message/rfc822 part, because that was already broken, and should be considered a separate issue.