Skip to content

Verify parameter names of function aliases #6335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Oct 13, 2020

Remaining errors that I'm not sure what to do with:

bzwrite(): Argument $bz of aliased function fwrite() is missing
bzflush(): Argument $bz of aliased function fflush() is missing
bzclose(): Argument $bz of aliased function fclose() is missing

@kocsismate kocsismate requested a review from nikic October 13, 2020 18:20
@nikic
Copy link
Member

nikic commented Oct 13, 2020

Remaining errors that I'm not sure what to do with:

bzwrite(): Argument $bz of aliased function fwrite() is missing
bzflush(): Argument $bz of aliased function fflush() is missing
bzclose(): Argument $bz of aliased function fclose() is missing

I think we should mark those as @implementation-alias. They're not documented as aliases either.

@kocsismate kocsismate force-pushed the stub-alias branch 3 times, most recently from 5e73122 to 1ede912 Compare October 14, 2020 11:04
@php-pulls php-pulls closed this in d6264b0 Oct 16, 2020
@kocsismate kocsismate deleted the stub-alias branch October 16, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants