Skip to content

in version 3 xdebug removed xdebug.default_enable #6324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bashkarev
Copy link

@nikic nikic requested a review from derickr October 12, 2020 12:34
@nikic
Copy link
Member

nikic commented Oct 12, 2020

Does xdebug 3 throw a warning when setting the old name?

@bashkarev
Copy link
Author

message Xdebug: [Config] The setting 'xdebug.default_enable' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.default_enable (See: https://xdebug.org/docs/errors#CFG-C-CHANGED) to php_log_err, it breaks tests

@derickr
Copy link
Member

derickr commented Oct 16, 2020

@nikic Only if E_DEPRECATED is part of error_reporting. For PHP 8 and higher it's OK to only have xdebug.mode=off, but for 7, it should have both still.

@php php deleted a comment from GrahamCampbell Oct 16, 2020
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine as a) XDebug 2 is not compatible with PHP 8 and b) run-tests.php is distributed by phpize and corresponds to a specific PHP version. While it's possible to use a newer run-tests.php against an older PHP version with XDebug 2, that's not what happens in a default configuration.

@php-pulls php-pulls closed this in f17b2a7 Oct 26, 2020
SammyK added a commit to DataDog/dd-trace-php that referenced this pull request Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants