Skip to content

Make iconv errno support test pass on Solaris. #6291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make iconv errno support test pass on Solaris. #6291

wants to merge 1 commit into from

Conversation

psumbera
Copy link
Contributor

@psumbera psumbera commented Oct 7, 2020

No description provided.

@cmb69
Copy link
Member

cmb69 commented Oct 7, 2020

So Solaris will accept an unknown encoding, and return an iconv descriptor which doesn't do any conversion at all? If so, this fix makes sense.

@psumbera
Copy link
Contributor Author

psumbera commented Oct 7, 2020

So Solaris will accept an unknown encoding, and return an iconv descriptor which doesn't do any conversion at all? If so, this fix makes sense.

Correct. If fromcode == tocode, it accepts whatever garbage.

cmb69
cmb69 approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

We may consider to apply it to PHP-7.3+.

@php-pulls php-pulls closed this in 07a4185 Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psumbera @cmb69