Fix #76735: Incorrect message in fopen on invalid mode #6187
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to log errors in `stream_opener` callbacks to the wrapper's error log, because otherwise we may pick up an unrelated `errno` or a most generic message.
Huh, that's pretty weird. What happens if we stop doing that? |
|
Well, depends on what we do instead. If we just pass the unmodified options, we likely may see multiple potentially bogus error messages sometimes. This is all about 5a21ab4 ; I wonder whether clearing the |
nikic
approved these changes
Sep 23, 2020
That seems likely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to log errors in
stream_openercallbacks to the wrapper'serror log, because otherwise we may pick up an unrelated
errnoor amost generic message.
Does anybody know why we toggle
REPORT_ERRORSwhen opening the stream:php-src/main/streams/streams.c
Line 2047 in c15e253