Promote warnings to Error in IMAP #6164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
imap-warning-to-error
branch
3 times, most recently
from
ce0c983 to
ce5e858
Compare
nikic
reviewed
Sep 21, 2020
| @@ -830,6 +835,17 @@ PHP_FUNCTION(imap_reopen) | |||
| RETURN_THROWS(); | |||
| } | |||
|
|
|||
| if (options && ((options & ~(OP_READONLY | OP_ANONYMOUS | OP_HALFOPEN | OP_EXPUNGE | CL_EXPUNGE)) != 0)) { | |||
There was a problem hiding this comment.
How do you determine which options are valid for which function?
There was a problem hiding this comment.
I pulled them from the PHP.net documentation, as I would expect the options which are documented there to work.
There was a problem hiding this comment.
The question then is whether imap_reopen only lists part of the flags because the rest are not supported, or because only the imap_open docs were updated ^^
Girgias
force-pushed
the
imap-warning-to-error
branch
from
ce5e858 to
a6acaa3
Compare
71 tasks
nikic
approved these changes
Sep 23, 2020
| *** Testing imap_fetch_overview() : usage variations *** | ||
| Create a temporary mailbox and add 1 msgs | ||
| .. mailbox '{%s}%s' created | ||
| .. mailbox '{127.0.0.1:143/norsh}INBOX.phpttest' created |
| *** Testing imap_fetchbody() : usage variations *** | ||
| Create a temporary mailbox and add 1 msgs | ||
| .. mailbox '{%s}%s' created | ||
| .. mailbox '{127.0.0.1:143/norsh}INBOX.phpttest' created |
| *** Testing imap_fetchheader() : usage variations *** | ||
| Create a temporary mailbox and add 1 msgs | ||
| .. mailbox '{%s}%s' created | ||
| .. mailbox '{127.0.0.1:143/norsh}INBOX.phpttest' created |
| @@ -830,6 +835,17 @@ PHP_FUNCTION(imap_reopen) | |||
| RETURN_THROWS(); | |||
| } | |||
|
|
|||
| if (options && ((options & ~(OP_READONLY | OP_ANONYMOUS | OP_HALFOPEN | OP_EXPUNGE | CL_EXPUNGE)) != 0)) { | |||
There was a problem hiding this comment.
The question then is whether imap_reopen only lists part of the flags because the rest are not supported, or because only the imap_open docs were updated ^^
| body = mail_fetchtext_full (imap_le_struct->imap_stream, msgno, &body_len, (argc == 3 ? flags : NIL)); | ||
| PHP_IMAP_CHECK_MSGNO(msgindex, 2); | ||
|
|
||
| /* TODO Shouldn't this pass msgindex??? */ |
| PHP_IMAP_CHECK_MSGNO(msgno, 2); | ||
|
|
||
| if (fromlength < 0 || fromlength > MAILTMPLEN) { | ||
| RETURN_THROWS(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered several potential bug and integer overflows.