Promote warnings to Error in COM extension #6141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
cmb69
reviewed
Sep 17, 2020
cmb69
reviewed
Sep 17, 2020
Girgias
force-pushed
the
com-warning-to-error
branch
2 times, most recently
from
0b4bd6a to
61f176a
Compare
cmb69
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
The failing test needs to be fixed, but otherwise looks good to me. Thanks!
Girgias
force-pushed
the
com-warning-to-error
branch
from
61f176a to
cd40a46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cmb69 can you have a look and give your opinion on the changes as you are the maintainer? :)