SPL use standard Error instead of custom exception (again) #6115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kocsismate and @nikic can I get your opinion on this once again as this is a trimmed down version of #4992? |
Girgias
force-pushed
the
sqpl-use-error-instead-custom-exceptio-v2
branch
from
edc69ac to
167c32c
Compare
nikic
reviewed
Sep 14, 2020
ext/spl/spl_directory.c
Outdated
| zend_throw_exception_ex(spl_ce_LogicException, 0, | ||
| "The parent constructor was not called: the object is in an " | ||
| "invalid state "); | ||
| zend_throw_error(NULL, "The parent constructor was not called: the object is in an invalid state "); |
There was a problem hiding this comment.
Suggested change
| zend_throw_error(NULL, "The parent constructor was not called: the object is in an invalid state "); | |
| zend_throw_error(NULL, "The parent constructor was not called: the object is in an invalid state"); |
|
@kocsismate Thoughts? |
|
@nikic I'm also in favour of these changes, and I also believe they should be safe enough to do. :) |
Girgias
force-pushed
the
sqpl-use-error-instead-custom-exceptio-v2
branch
from
167c32c to
9192e2d
Compare
nikic
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly more conservative then last time as those are programming errors and therefore should probably use Errors instead of Exceptions.