Promote a few remaining errors in ext/standard #6110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
changed the title
kocsismate
commented
Sep 10, 2020
kocsismate
commented
Sep 10, 2020
kocsismate
force-pushed
the
standard-warning
branch
from
afdf73b to
f33f924
Compare
Girgias
reviewed
Sep 10, 2020
kocsismate
changed the title
kocsismate
force-pushed
the
standard-warning
branch
4 times, most recently
from
4def16d to
11f882e
Compare
nikic
reviewed
Sep 11, 2020
nikic
reviewed
Sep 11, 2020
nikic
reviewed
Sep 11, 2020
kocsismate
force-pushed
the
standard-warning
branch
from
11f882e to
1680d90
Compare
|
Looks like the openssl parameter renames snuck in here :) |
|
Thanks for noticing, I'm working on the renames indeed. Also, I'll fix the tests, I haven't updated them yet. |
kocsismate
force-pushed
the
standard-warning
branch
2 times, most recently
from
730490c to
08a6000
Compare
nikic
reviewed
Sep 14, 2020
| Subject: Test Subject | ||
|
|
||
| A Message | ||
| TypeError: Header "orig-date" must be of type string, array given |
There was a problem hiding this comment.
We're losing test coverage here, as previously multiple errors were checked with one call...
| efree(posix_mode); | ||
| RETURN_FALSE; | ||
| RETURN_THROWS(); |
There was a problem hiding this comment.
As this now throws ValueError, we should make it consistent between Linux & Windows. I.e. move this outside the ifndef, but also allow b (I think we may require that first char is r/w and only allow b as second).
There was a problem hiding this comment.
Hopefully I managed to find the condition you imagined ^^
kocsismate
force-pushed
the
standard-warning
branch
from
08a6000 to
9a2b786
Compare
nikic
reviewed
Sep 15, 2020
nikic
approved these changes
Sep 15, 2020
This reverts commit 24e9599.
kocsismate
force-pushed
the
standard-warning
branch
from
20d941d to
448f74d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved a few error messages in the meanwhile.
Also, I did a few related changes in ext/mbstring for the sake of consistency.