Remove specialization of SPEC(OBSERVER) handlers #6060
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine. |
|
I've switched Travis to a newer Ubuntu version, let's see if that fixed the spurious compiler warning. |
SammyK
force-pushed
the
observer/remove-op-spec
branch
from
1fac7e3 to
087ced9
Compare
|
@dstogov All specialization of observer handlers has been removed so this is ready for a final review. |
|
Travis shows compilation errors. |
|
@dstogov 🤦 Sorry about that. Even with |
|
Merged as 9e94bcf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #5857, that removes specialization of
SPEC(OBSERVER)handlers per @dstogov's request.Right now this removes
RETVALspecialization. (Thanks for the help @nikic!) Do we need to remove theCONST|TMP|VAR|CVspecialization as well?