Update PHP-Parser from 4.3.0 to 4.9.0 #6036
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP-Parser 4.3.0 failed to recognize that the `match` keyword could be used as a class constant name. 4.9.0 also adds support for keywords in namespaced names. See https://github.com/nikic/PHP-Parser/releases So forcing regeneration of spl_iterators.stub.php failed. PECL extensions using gen_stub.php would also be affected by the same issue. ``` ext/spl/spl_iterators.stub.php public function __construct(Iterator $iterator, string $regex, int $mode = self::MATCH, int $flags = 0, int $preg_flags = 0) {} ``` Testing: I successfully regenerated stubs by setting forceRegeneration to true and running `touch **/*.stub.php; make`. The stubs did not change, as expected.
nikic
approved these changes
Aug 23, 2020
|
@TysonAndre Thanks! This upgrade will also allow us to remove the hack from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP-Parser 4.3.0 failed to recognize that the
matchkeyword could beused as a class constant name.
4.9.0 also adds support for keywords in namespaced names.
See https://github.com/nikic/PHP-Parser/releases
So forcing regeneration of spl_iterators.stub.php failed.
PECL extensions using gen_stub.php would also be affected
by the same issue for those keywords.
Testing: I successfully regenerated stubs by setting forceRegeneration to true
and running
touch **/*.stub.php; make.The stubs did not change, as expected.
CC @nikic @kocsismate @cmb69