Add more precise type info for stubs #6005
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
force-pushed
the
array-access-stub
branch
from
ecb3b00 to
37df2f8
Compare
kocsismate
changed the title
kocsismate
force-pushed
the
array-access-stub
branch
from
37df2f8 to
2e0f388
Compare
kocsismate
commented
Aug 19, 2020
| @@ -227,7 +226,7 @@ function numfmt_parse_currency(NumberFormatter $fmt, string $value, &$currency, | |||
| /** @param int|float $value */ | |||
| function numfmt_set_attribute(NumberFormatter $fmt, int $attr, $value): bool {} | |||
|
|
|||
| function numfmt_get_attribute(NumberFormatter $fmt, int $attr): int|double|false {} | |||
| function numfmt_get_attribute(NumberFormatter $fmt, int $attr): int|float|false {} | |||
There was a problem hiding this comment.
Maybe we should check against this in gen_stub?
kocsismate
force-pushed
the
array-access-stub
branch
4 times, most recently
from
62102b4 to
90da7d4
Compare
nikic
reviewed
Aug 24, 2020
kocsismate
force-pushed
the
array-access-stub
branch
2 times, most recently
from
9bc84f1 to
c74a8fe
Compare
nikic
reviewed
Sep 1, 2020
| @@ -227,7 +226,7 @@ function numfmt_parse_currency(NumberFormatter $fmt, string $value, &$currency, | |||
| /** @param int|float $value */ | |||
| function numfmt_set_attribute(NumberFormatter $fmt, int $attr, $value): bool {} | |||
|
|
|||
| function numfmt_get_attribute(NumberFormatter $fmt, int $attr): int|double|false {} | |||
| function numfmt_get_attribute(NumberFormatter $fmt, int $attr): int|float|false {} | |||
There was a problem hiding this comment.
Maybe we should check against this in gen_stub?
| Z_PARAM_ZVAL(value) | ||
| Z_PARAM_OPTIONAL | ||
| Z_PARAM_LONG(timeout) | ||
| Z_PARAM_LONG(retries) |
There was a problem hiding this comment.
Yeah, I had a similar feeling when migrating this code to the new ZPP :D
There was a problem hiding this comment.
From the docs (emphasis mine): "snmp3_set() is used to set the value of an SNMP object specified by the object_id."
| @@ -57,20 +47,19 @@ public function getIteratorMode() {} | |||
| public function offsetExists($index) {} | |||
There was a problem hiding this comment.
Wanted to say that these should have an int type now, but ... gah, we can't :(
kocsismate
force-pushed
the
array-access-stub
branch
from
5723b49 to
b8598af
Compare
nikic
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to move a bunch of type info from PHPDoc to actual declaration, while fixing a few related things.
After this PR, most of the type info will be added as a declaration, except for:
resourcetypes, which we shouldn't worry aboutarray|string,array|string|nullandarray|string|inttypesarray|inttypesstring|inttypesGMP|int|bool|stringtypes in ext/gmpcallabletypes in ext/session and ext/xmlcallable|int,scalar, types where multiple classes are involved