Better c zend api

[Girgias]

This is an attempt to make the API of the Zend engine easier to use.

Functions which only return SUCCESS and don't need to return such a value due to other engine API are changed to void

Functions which return the values SUCCESS or FAILURE exclusively are changed to return the corresponding enum ZEND_RESULT_CODE as they have boolean semantics but cannot use the native bool type and the return value needs to be compared to SUCCESS/FAILURE

Functions returning/accepting a boolean value are clearly marked so.

I'm aware of the JIT failure, but I would like to know the opinions of others on this change before I pursue fixing them.

[nikic]

I don't like the ZEND_RESULT_CODE name, type name should not be uppercase... At the least this should be zend_result_code, but maybe zend_result is better, as this is heavily used.

[Girgias]

I don't like the ZEND_RESULT_CODE name, type name should not be uppercase... At the least this should be zend_result_code, but maybe zend_result is better, as this is heavily used.

Should I typedef ZEND_RESULT_CODE to zend_result and use that?

[nikic]

From a quick scroll through, this looks reasonable to me.

[nikic]

Spurious change.

[Girgias]

@nikic do you have any idea what I would need to do/change in the JIT at line 7930 of zend_jit_x86.dasc ( | EXT_CALL zend_is_true, r0 such that I can change the signature of zend_is_true() from into to bool, as it segfaults currently and I don't exactly see how I can fix the JIT in this regards.
This could also be left to a follow-up PR.

[testAccountDeltas]

BUG in _str_dtor

https://github.com/php/php-src/blob/master/Zend/zend_string.c#L72

Critical error in zend_hash_destroy function on pointer deallocation

php-src/Zend/zend_hash.c

Line 1609 in 14830ab

pefree(HT_GET_DATA_ADDR(ht), GC_FLAGS(ht) & IS_ARRAY_PERSISTENT);

When closing the application from

php-src/main/main.c

Line 1831 in 521c36c

zend_interned_strings_deactivate();

Fix that fixes the error when closing
zend_hash_init(interned_strings, 1024, NULL, NULL, permanent);

Assign emptiness (NULL)

[testAccountDeltas]

BUG FIX!!!! , 1

ZEND_API void zend_interned_strings_activate(void){
zend_init_interned_strings_ht(&CG(interned_strings), 1);
}

[Girgias]

Please open a new PR and or a bug ticket