Promote warnings to exceptions in ext/curl #5963
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Aug 9, 2020
| @@ -104,7 +104,7 @@ static int php_curl_option_str(php_curl *ch, zend_long option, const char *str, | |||
| CURLcode error = CURLE_OK; | |||
|
|
|||
| if (strlen(str) != len) { | |||
| php_error_docref(NULL, E_WARNING, "Curl option contains invalid characters (\\0)"); | |||
| zend_type_error("%s(): cURL option cannot contain any null-bytes", get_active_function_name()); | |||
There was a problem hiding this comment.
Maybe it would be worth to introduce a new function that adds the current function/method name to the beginning. It might be useful if we start adding OO interfaces.
ext/curl/interface.c
Outdated
| @@ -3292,7 +3301,7 @@ PHP_FUNCTION(curl_close) | |||
| ch = Z_CURL_P(zid); | |||
|
|
|||
| if (ch->in_callback) { | |||
| php_error_docref(NULL, E_WARNING, "Attempt to close cURL handle from a callback"); | |||
| zend_throw_error(NULL, "curl_close(): Attempt to close cURL handle from a callback"); | |||
kocsismate
force-pushed
the
curl-warning
branch
5 times, most recently
from
8d56a60 to
b6e248a
Compare
nikic
reviewed
Aug 11, 2020
71 tasks
kocsismate
force-pushed
the
curl-warning
branch
from
b6e248a to
24d6483
Compare
nikic
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be checked if there is any other warnings in ext/curl that should be promoted