Add type information to test-runner #5942
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Aug 6, 2020
run-tests.php
Outdated
| @@ -1665,6 +1685,9 @@ function kill_children(array $children) | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * @return true|void | |||
| */ | |||
There was a problem hiding this comment.
Where does the true come from? Should be just void.
There was a problem hiding this comment.
From line 1712, but will change that to void then.
Girgias
force-pushed
the
type-declarations-test-runner
branch
from
ea2a67a to
7bdc401
Compare
nikic
reviewed
Aug 6, 2020
run-tests.php
Outdated
| @@ -1706,7 +1706,7 @@ function run_worker(): void | |||
| ]); | |||
| } | |||
|
|
|||
| return; | |||
| return true; | |||
There was a problem hiding this comment.
You can add a return type to anonys. functions as well. The one on line 1702 is an example :)
There was a problem hiding this comment.
Did that in the, hopefully, final pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've bumped the minimal PHP version to 7.1.0 such that the
voidreturn type can be used.This should help with refactoring and making it less dependable on global state, if this is something we want to pursue.