[Proposal] Warn about the loss of precision in binary/octal/hexadecimal literals #5921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TysonAndre
force-pushed
the
hex-precision-loss-warning
branch
from
0a14902 to
752cf09
Compare
TysonAndre
changed the title
TysonAndre
force-pushed
the
hex-precision-loss-warning
branch
from
752cf09 to
302de7f
Compare
Emit an E_COMPILE_WARNING if these are seen in hexadecimal, octal, or binary literals. - E_COMPILE_WARNING is also emitted for "Octal escape sequence overflow" but it's been long enough to consider changing that. See phpGH-4758. - Making this proposal suddenly a ParseError in php 8.1 seems too soon. I expect this to behave the same on 32-bit and 64-bit builds (floats are 64 bits on both) For example, `0xffff_ffff_ffff_f400` overflows and becomes the **float** `0xffff_ffff_ffff_f000`. This PR will warn about that. Instead of using `0xffff_ffff_ffff_f400` with binary bitwise operands, most code should use the signed 64-bit int `~0xbff`. - E.g. PHP code ported from cryptography algorithms or other C code doing bitwise operations.
TysonAndre
force-pushed
the
hex-precision-loss-warning
branch
from
302de7f to
0a67213
Compare
The libxml borked warning was unrelated Fix 32-bit builds and soap tests. Make it so the same warnings would be emitted both for 32-bit and 64-bit builds
TysonAndre
force-pushed
the
hex-precision-loss-warning
branch
from
0a67213 to
d479c63
Compare
|
This probably needs an RFC, and at least a discussion on internals. |
|
This looks sensible. I think a mail to the mailing list might be enough if there are no objections. @TysonAndre Are you planning on pursuing this? |
|
Closing since there was no response. @TysonAndre Feel free to reopen this if work continues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit an E_COMPILE_WARNING if these are seen in hexadecimal,
octal, or binary literals.
but it's been long enough to consider changing that. See Call error handler for E_COMPILE_WARNING #4758.
I expect this to behave the same on 32-bit and 64-bit builds
(floats are 64 bits on both)
For example,
0xffff_ffff_ffff_f400overflows and becomes the float0xffff_ffff_ffff_f000. This PR will warn about that.Instead of using
0xffff_ffff_ffff_f400with binary bitwise operands,most code should use the signed 64-bit int
~0xbff.or other C code doing bitwise operations.