Fix #79895: support = in PHP_CHECK_GCC_ARG m4 macro #5890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is okay and we should fix it for released versions. For master, I think we should just kill this macro in favor of AX_CHECK_COMPILE_FLAG, unless there's some relevant difference that I'm missing. |
|
Keeping PHP_CHECK_GCC_ARG might be convenient for extensions that support a wide array of PHP versions. Personally I don't care, since I already need to vendor a custom version of PHP_CHECK_GCC_ARG for PHP 5.3-8.0 compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.