Skip to content

Fix warning of strict-prototypes #5887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

twose
Copy link
Member

@twose twose commented Jul 22, 2020

I compiled all header files with gcc and fixed all -Wstrict-prototypes warnings in the output
Every time I do a similar fix is due to some annoying warnings appeared when I compiled my extension...
It would be great if someone could solve it in CI

Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming -Wstrict-prototypes only warns on declarations and not definitions, it should be fine to add it to our default warning configuration. Maybe @Girgias is interested in looking into this.

@twose
Copy link
Member Author

twose commented Jul 22, 2020

Assuming -Wstrict-prototypes only warns on declarations and not definitions, it should be fine to add it to our default warning configuration. Maybe @Girgias is interested in looking into this.

Yes, only declarations, but I still sync it to the source files, it looks better

@php-pulls php-pulls closed this in 6e92487 Jul 22, 2020
@twose twose deleted the strict-prototypes branch August 30, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants