Skip to content

Gmp warning to error #5882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Gmp warning to error #5882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
74e6c22
ValueError in GMP
Girgias Jul 21, 2020
f4c95f1
TypeError in GMP ext
Girgias Jul 21, 2020
9b360b4
Division/Modulo by 0 error in GMP extension
Girgias Jul 21, 2020
547e101
TODO Notes
Girgias Jul 21, 2020
14661a1
Refactor gmp_fact()
Girgias Jul 21, 2020
b78eb76
Remove unused function
Girgias Jul 22, 2020
95ac942
Review
Girgias Jul 31, 2020
0c0818b
Emit correct exception directly
Girgias Aug 4, 2020
5151786
ValueError for even root of negative number
Girgias Aug 4, 2020
471a8fa
gmp_invert improvement
Girgias Aug 4, 2020
0ba169e
Second batch of reviews
Girgias Aug 6, 2020
d85454f
Refactor gmp_fact again
Girgias Aug 6, 2020
b0c77ff
Fix test
Girgias Aug 6, 2020
670896b
Revert base indication in conversion failure
Girgias Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
316 changes: 163 additions & 153 deletions ext/gmp/gmp.c
View file
Open in desktop

Large diffs are not rendered by default.

94 changes: 47 additions & 47 deletions ext/gmp/gmp.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,104 +7,104 @@ class GMP
}

/** @param int|bool|string $number */
function gmp_init($number, int $base = 0): GMP|false {}
function gmp_init($number, int $base = 0): GMP {}

function gmp_import(string $data, int $word_size = 1, int $options = GMP_MSW_FIRST | GMP_NATIVE_ENDIAN): GMP|false {}
function gmp_import(string $data, int $word_size = 1, int $options = GMP_MSW_FIRST | GMP_NATIVE_ENDIAN): GMP {}

/** @param GMP|int|bool|string $gmpnumber */
function gmp_export($gmpnumber, int $word_size = 1, int $options = GMP_MSW_FIRST | GMP_NATIVE_ENDIAN): string|false {}
function gmp_export($gmpnumber, int $word_size = 1, int $options = GMP_MSW_FIRST | GMP_NATIVE_ENDIAN): string {}

/** @param GMP|int|bool|string $gmpnumber */
function gmp_intval($gmpnumber): int {}

/** @param GMP|int|bool|string $gmpnumber */
function gmp_strval($gmpnumber, int $base = 10): string|false {}
function gmp_strval($gmpnumber, int $base = 10): string {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_add($a, $b): GMP|false {}
function gmp_add($a, $b): GMP {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_sub($a, $b): GMP|false {}
function gmp_sub($a, $b): GMP {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_mul($a, $b): GMP|false {}
function gmp_mul($a, $b): GMP {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_div_qr($a, $b, int $round = GMP_ROUND_ZERO): array|false {}
function gmp_div_qr($a, $b, int $round = GMP_ROUND_ZERO): array {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_div_q($a, $b, int $round = GMP_ROUND_ZERO): GMP|false {}
function gmp_div_q($a, $b, int $round = GMP_ROUND_ZERO): GMP {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_div_r($a, $b, int $round = GMP_ROUND_ZERO): GMP|false {}
function gmp_div_r($a, $b, int $round = GMP_ROUND_ZERO): GMP {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
* @alias gmp_div_q
*/
function gmp_div($a, $b, int $round = GMP_ROUND_ZERO): GMP|false {}
function gmp_div($a, $b, int $round = GMP_ROUND_ZERO): GMP {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_mod($a, $b): GMP|false {}
function gmp_mod($a, $b): GMP {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_divexact($a, $b): GMP|false {}
function gmp_divexact($a, $b): GMP {}

/** @param GMP|int|bool|string $a */
function gmp_neg($a): GMP|false {}
function gmp_neg($a): GMP {}

/** @param GMP|int|bool|string $a */
function gmp_abs($a): GMP|false {}
function gmp_abs($a): GMP {}

/** @param GMP|int $a */
function gmp_fact($a): GMP|false {}
/** @param GMP|int|bool|string $a */
function gmp_fact($a): GMP {}

/** @param GMP|int|bool|string $a */
function gmp_sqrt($a): GMP|false {}
function gmp_sqrt($a): GMP {}

/** @param GMP|int|bool|string $a */
function gmp_sqrtrem($a): array|false {}
function gmp_sqrtrem($a): array {}

/** @param GMP|int|bool|string $a */
function gmp_root($a, int $nth): GMP|false {}
function gmp_root($a, int $nth): GMP {}

/** @param GMP|int|bool|string $a */
function gmp_rootrem($a, int $nth): array|false {}
function gmp_rootrem($a, int $nth): array {}

/** @param GMP|int|bool|string $base */
function gmp_pow($base, int $exp): GMP|false {}
function gmp_pow($base, int $exp): GMP {}

/**
* @param GMP|int|bool|string $base
* @param GMP|int|bool|string $exp
* @param GMP|int|bool|string $mod
*/
function gmp_powm($base, $exp, $mod): GMP|false {}
function gmp_powm($base, $exp, $mod): GMP {}

/** @param GMP|int|bool|string $a */
function gmp_perfect_square($a): bool {}
Expand All @@ -113,25 +113,25 @@ function gmp_perfect_square($a): bool {}
function gmp_perfect_power($a): bool {}

/** @param GMP|int|bool|string $a */
function gmp_prob_prime($a, int $reps = 10): int|false {}
function gmp_prob_prime($a, int $reps = 10): int {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_gcd($a, $b): GMP|false {}
function gmp_gcd($a, $b): GMP {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_gcdext($a, $b): array|false {}
function gmp_gcdext($a, $b): array {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_lcm($a, $b): GMP|false {}
function gmp_lcm($a, $b): GMP {}

/**
* @param GMP|int|bool|string $a
Expand All @@ -143,85 +143,85 @@ function gmp_invert($a, $b): GMP|false {}
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_jacobi($a, $b): int|false {}
function gmp_jacobi($a, $b): int {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_legendre($a, $b): int|false {}
function gmp_legendre($a, $b): int {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_kronecker($a, $b): int|false {}
function gmp_kronecker($a, $b): int {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_cmp($a, $b): int|false {}
function gmp_cmp($a, $b): int {}

/** @param GMP|int|bool|string $a */
function gmp_sign($a): int|false {}
function gmp_sign($a): int {}

/** @param GMP|int|bool|string $seed */
function gmp_random_seed($seed): ?bool {}
function gmp_random_seed($seed): void {}

function gmp_random_bits(int $bits): GMP|false {}
function gmp_random_bits(int $bits): GMP {}

/**
* @param GMP|int|bool|string $min
* @param GMP|int|bool|string $max
**/
function gmp_random_range($min, $max): GMP|false {}
function gmp_random_range($min, $max): GMP {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_and($a, $b): GMP|false {}
function gmp_and($a, $b): GMP {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_or($a, $b): GMP|false {}
function gmp_or($a, $b): GMP {}

/** @param GMP|int|bool|string $a */
function gmp_com($a): GMP|false {}
function gmp_com($a): GMP {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_xor($a, $b): GMP|false {}
function gmp_xor($a, $b): GMP {}

function gmp_setbit(GMP $a, int $index, bool $set_clear = true): ?bool {}
function gmp_setbit(GMP $a, int $index, bool $set_clear = true): void {}

function gmp_clrbit(GMP $a, int $index): ?bool {}
function gmp_clrbit(GMP $a, int $index): void {}

/** @param GMP|int|bool|string $a */
function gmp_testbit($a, int $index): bool {}

/** @param GMP|int|bool|string $a */
function gmp_scan0($a, int $start): int|false {}
function gmp_scan0($a, int $start): int {}

/** @param GMP|int|bool|string $a */
function gmp_scan1($a, int $start): int|false {}
function gmp_scan1($a, int $start): int {}

/** @param GMP|int|bool|string $a */
function gmp_popcount($a): int|false {}
function gmp_popcount($a): int {}

/**
* @param GMP|int|bool|string $a
* @param GMP|int|bool|string $b
*/
function gmp_hamdist($a, $b): int|false {}
function gmp_hamdist($a, $b): int {}

/** @param GMP|int|bool|string $a */
function gmp_nextprime($a): GMP|false {}
function gmp_nextprime($a): GMP {}

/** @param GMP|int|bool|string $a */
function gmp_binomial($a, int $b): GMP|false {}
function gmp_binomial($a, int $b): GMP {}
Loading