Refactor user streams #5876
Closed
Refactor user streams #5876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there are no objections I'll merge this at the end of the week. |
nikic
reviewed
Jul 28, 2020
main/streams/userspace.c
Outdated
| zend_string *protocol, *classname; | ||
| struct php_user_stream_wrapper * uwrap; | ||
| zend_string *protocol; | ||
| struct php_user_stream_wrapper *uwrap = (struct php_user_stream_wrapper *)ecalloc(1, sizeof(*uwrap));; |
There was a problem hiding this comment.
Please keep this after the zpp call and use a variable for the ce argument.
Girgias
force-pushed
the
zpp-ce-stream-func
branch
from
0dee55c to
b911351
Compare
nikic
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a proper class name ZPP check and drop now useless
classnameelement from the struct.