Skip to content

Consistent types #5845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Consistent types #5845

wants to merge 2 commits into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jul 12, 2020

Align types with their expected ones.

This allows to voidify some functions which only checked that the value is non-negative.

Girgias added 2 commits July 12, 2020 02:37
@Girgias
Use consistent types
b58436d 
uint32_t type for argument count
size_t for length of char*
zend_bool for a zval bool arg
@Girgias
Add TODO note
da4b5ab
@php-pulls php-pulls closed this in 4f3eccf Jul 13, 2020
@carusogabriel carusogabriel added this to the PHP 8.0 milestone Jul 13, 2020
@Girgias Girgias deleted the consistent-types branch July 15, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Girgias @nikic @carusogabriel