Additional test for disabled function re-declare #5817
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #5473
Bug: 79382
For disabled functions, there is currently a test:
This test passes, but I think PHP is still using the internal
strlen
implementation here because even if I change the user-land function declaration to return another value, the test still passes.This PR adds a new test that re-declares disbaled
substr
function (which has no internal optimizations).Thank you 🙏🏿.