[RFC] Typed class constants

[moliata]

RFC: https://wiki.php.net/rfc/typed_class_constants

[moliata]

This needs to be optional_type_without_static instead of type_expr_without_static but since there are 4 shift/reduce conflicts using the former one, I am temporarily using type_expr_without_static.

...this is also the reason behind a bunch of failing tests.

[kocsismate]

I only have a few cosmetic questions/suggestions which shouldn't affect the RFC too much in so early a phase. :)

[iluuu1994]

@moliata Are you planning on pursuing this RFC?

[moliata]

Hey, @iluuu1994

I do plan to continue pursuing this RFC, however, this implementation isn't really good and I will rewrite it completely from scratch when I get the time to do so. For now, I think it's fine that we close this PR but leave the RFC page still available on the wiki.

Best regards,
Ben

[iluuu1994]

Thanks @moliata.

[kocsismate]

Hi @moliata,

Recently, I wanted to fix your problem with the parser. Even though I didn't reach far, @bwoebi helped me. Afterwards, I fixed a few smaller issues with your implementation... so your RFC now has an almost complete implementation: https://github.com/php/php-src/compare/master...kocsismate:php-src:const-type?expand=1

I strongly recommend though to split the abstract constant part of your proposal because of its possible controversiality and additional - unnecessary - complexity. I didn't even try to implement this.

[moliata]

@kocsismate For reference, I was confused about you mentioning the abstract part of my proposal. Apparently, Mark Niebergall modified my original proposal on the wiki, included abstract constant part and credited himself. I do not condone nor support that, so I plan to rewrite the original proposal.

[kocsismate]

@moliata Did you have the chance to make some progress with the RFC?

[moliata]

@kocsismate Despite having done some progress during the holidays, I have come to understanding that due to time constraints and many exam sessions that I am currently having, I won't be able to work on this properly any time soon. I would be glad if someone took upon this RFC and refined it.

[kocsismate]

@moliata OK, I'd be happy to take the RFC over - of course by properly crediting your previous work. :)

The only additional thing I want is to make it possible to add types to global constants (const int FOO = 1). I need it for the stubs. If it's controversial then I'll split this to a separate vote. :)

[kocsismate]

@moliata I've updated your original RFC and updated your implementation (#10444). The new version of the RFC doesn't contain anything surprising, it basically only makes typed constants work with objects - which are now supported by PHP.

[moliata]

@kocsismate Looks great to me! Thank you so much for your work and I wish you the best of luck during the voting phase.