Removed "oci_internal_debug" and its alias. Also deprecated "ocifetchinto" #5810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
reviewed
Jul 5, 2020
…ted the "ocifetchinto" function.
|
@nikic @kocsismate I deleted the reflection tests and rebased master. |
kocsismate
reviewed
Jul 7, 2020
|
@kocsismate I also removed part of a test which was failing due to one of the ZPP changes. |
|
Now it looks good to me! |
jrfnl
added a commit
to PHPCompatibility/PHPCompatibility
that referenced
this pull request
Aug 10, 2020
…ebug() > oci_internal_debug() and its alias ociinternaldebug() have been removed. Refs: * https://github.com/php/php-src/blob/c0172aa2bdb9ea223c8491bdb300995b93a857a0/UPGRADING#L325 * php/php-src#5810 * php/php-src@11f4a5e Includes adjusted unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed "oci_internal_debug" and its alias. Also deprecated "ocifetchinto".