Fix bug #79787 : mb_strimwidth does not trim string #5807
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x-xiang
changed the title
If so, you need to rebase with the |
Done. @carusogabriel |
|
This code is so hard to understand :( |
Thanks, I really can't find a better solution. @nikic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the string end with full-width character and its width is one greater than the desired trimming width，trimmaker is alse a half-width character, which will cause mb_strimwidth not to trim.
Affects all stable versions of PHP.
Original bug: https://bugs.php.net/bug.php?id=79787