Skip to content

Add README for ext/mysqli tests #5804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

tiffany-taylor
Copy link
Member

I created a readme file to explain what's necessary to run the ext/mysqli tests. I used the pdo_mysql README as a rough example to write this.

I'm unsure if the statement

The MySQL user used to run the tests must have full permissions on the test database.

is accurate with ext/mysqli. I'm guessing that the statement is correct, given that a database and test user are required to run the tests. If I'm wrong, please correct me.

@Girgias
Copy link
Member

Girgias commented Jul 3, 2020

Maybe it would be nice to provide the command to create the test DB:
mysql -u root -e "CREATE DATABASE test"

@tiffany-taylor
Copy link
Member Author

tiffany-taylor commented Jul 3, 2020

Maybe it would be nice to provide the command to create the test DB:
mysql -u root -e "CREATE DATABASE test"

I would think that would be assumed, but that also assumes the person has an understanding of MySQL at the outset. I can add instructions on what's needed for setup, if that is desired.

@Girgias
Copy link
Member

Girgias commented Jul 3, 2020

Maybe it would be nice to provide the command to create the test DB:
mysql -u root -e "CREATE DATABASE test"

I would think that would be assumed, but that also assumes the person has an understanding of MySQL at the outset. I can add instructions on what's needed for setup, if that is desired.

I don't know how all databases work and what their CLI interface are, thus I think it would be a nice addition, maybe also a mention that the tables needed to run the tests are created and torn down by the test suite just to prevent someone from creating a dedicated table in the database.

@tiffany-taylor
Copy link
Member Author

It might be a good idea to add similar instructions to the pdo_mysql README as well...

@tiffany-taylor
Copy link
Member Author

tiffany-taylor commented Jul 3, 2020

@Girgias how does this sound?

Forgot to add an explanation about creating a dedicated table, which is now included in the latest commit.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@php-pulls php-pulls closed this in 48eb635 Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants