-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add README for ext/mysqli tests #5804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe it would be nice to provide the command to create the test DB: |
I would think that would be assumed, but that also assumes the person has an understanding of MySQL at the outset. I can add instructions on what's needed for setup, if that is desired. |
I don't know how all databases work and what their CLI interface are, thus I think it would be a nice addition, maybe also a mention that the tables needed to run the tests are created and torn down by the test suite just to prevent someone from creating a dedicated table in the database. |
It might be a good idea to add similar instructions to the pdo_mysql README as well... |
@Girgias how does this sound? Forgot to add an explanation about creating a dedicated table, which is now included in the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I created a readme file to explain what's necessary to run the ext/mysqli tests. I used the pdo_mysql README as a rough example to write this.
I'm unsure if the statement
is accurate with ext/mysqli. I'm guessing that the statement is correct, given that a database and test user are required to run the tests. If I'm wrong, please correct me.