-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Attribute Amendments #5751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Attribute Amendments #5751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid unnecessary back and forth in the AST representation, let's drop the grouped attribute syntax, which will dropped anyway once https://wiki.php.net/rfc/shorter_attribute_syntax finishes voting. |
nikic
reviewed
Jun 23, 2020
Attribute grouping has been removed from the PR. |
nikic
reviewed
Jun 26, 2020
@nikic All review comments have been addressed. I rebased the PR on latest master and squashed all commits into a single one. |
nikic
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements all changes that have been proposed by @beberlei and myself in RFC: Attribute Amendments. Support for attribute grouping is left out because Shorter Attribute Syntax will likely make it obsolete. All new features are demonstrated in this little example:
These are the extensions to existing APIs: