check for broken libzip versions #5738
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notice the check for 1.3.1 is only needed for master, where the safety conditional was removed, as testing P.S. Well, looks like the "a" char is not there anymore with current master |
nikic
reviewed
Jun 18, 2020
ext/zip/config.m4
Outdated
| @@ -6,6 +6,30 @@ PHP_ARG_WITH([zip], | |||
| if test "$PHP_ZIP" != "no"; then | |||
| PKG_CHECK_MODULES([LIBZIP], [libzip >= 0.11]) | |||
There was a problem hiding this comment.
After playing around with pkg-config a bit, it looks like this should also work:
PKG_CHECK_MODULES([LIBZIP], [libzip >= 0.11 libzip != 1.3.1 libzip != 1.7.0])
It prints something like:
Requested 'libzip != 1.5.1' but version of libzip is 1.5.1
There was a problem hiding this comment.
Rewritten (or add it in your PR)
BTW, if wanted for 7.3 we can use pierrejoye/php_zip@353ecec (ping @cmb69 )
remicollet
force-pushed
the
issue-libzip170
branch
from
2993db8 to
29de999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see php/php-tasks#8